-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AI Tools #4505
Fix AI Tools #4505
Conversation
@amteusch , thanks for the contribution. We will add a test on our side. Could you please add a line to CHANGELOG.md? |
@nmanovic added the line but I think I didn't rebase properly... let me know what needs fixing |
@amteusch , could you please merge our develop branch into your branch? You should have only 2 files in 'Files changed'. |
@nmanovic better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amteusch , thanks for the great contribution! We will add a test to avoid such issues in the future.
@ivk , could you please prepare a regression test for issue? Please work with @kirill-sizov to implement a way to test serverless functions. |
Have you installed the nuclio tool? I found I needed to follow additional instructions for the fix to work properly. Not ruling out the possibilty of a bug, but maybe this could help narrow down the problem |
Motivation and context
Pretty simple changes should fix #4432
How has this been tested?
Only tested by building locally, following instructions from here. DEXTR
and YOLOv3
worked but these are the only ones I tried. On Ubuntu 20.04.4. Please advise about tests and change log, I did not do either of these from the checklist but I'm not sure if they are needed for this small fix
Checklist
develop
branchI have updated the documentation accordinglyI have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.