Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset import for Datumaro format #4544

Merged
merged 22 commits into from
Nov 1, 2022
Merged

Fix dataset import for Datumaro format #4544

merged 22 commits into from
Nov 1, 2022

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented Apr 4, 2022 •
edited by zhiltsov-max
Loading

Motivation and context

Fix #4410

  • Fixed project import and export for Datumaro, KITTI and VGGFace2 formats
  • Added project import/export tests

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max mentioned this pull request Aug 22, 2022
Closed
8 tasks
@sizov-kirill sizov-kirill changed the title [WIP] Fix dataset import for Datumaro format Fix dataset import for Datumaro format Aug 22, 2022
@sizov-kirill sizov-kirill changed the title Fix dataset import for Datumaro format [WIP] Fix dataset import for Datumaro format Aug 24, 2022
@sizov-kirill sizov-kirill changed the title [WIP] Fix dataset import for Datumaro format Fix dataset import for Datumaro format Aug 24, 2022
@sizov-kirill sizov-kirill changed the title Fix dataset import for Datumaro format [WIP] Fix dataset import for Datumaro format Aug 24, 2022
@sizov-kirill sizov-kirill changed the title [WIP] Fix dataset import for Datumaro format Fix dataset import for Datumaro format Aug 26, 2022
zhiltsov-max
zhiltsov-max reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasakova-anastasia , could you also update the formats section of README.md?

@zhiltsov-max zhiltsov-max mentioned this pull request Oct 19, 2022
Merged
7 tasks
@yasakova-anastasia
Copy link
Contributor

@yasakova-anastasia , could you also update the formats section of README.md?

Updated.

zhiltsov-max
zhiltsov-max reviewed Oct 24, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@yasakova-anastasia @zhiltsov-max
Update README.md
48c8c3c 
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
SpecLad
SpecLad requested changes Oct 24, 2022
View reviewed changes
cvat/apps/dataset_manager/tests/test_rest_api_formats.py Outdated Show resolved Hide resolved
cvat/apps/dataset_manager/tests/test_rest_api_formats.py Outdated Show resolved Hide resolved
cvat/apps/dataset_manager/tests/test_rest_api_formats.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@cvat-ai cvat-ai deleted a comment from github-actions bot Oct 25, 2022
@cvat-ai cvat-ai deleted a comment from github-actions bot Oct 26, 2022
@yasakova-anastasia
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

SpecLad
SpecLad approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@SpecLad SpecLad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the GitHub actions didn't run for some reason? Might need to push the branch again.

@yasakova-anastasia
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@cvat-ai cvat-ai deleted a comment from github-actions bot Nov 1, 2022
@bsekachev
Copy link
Member

We have different test failed in two runnings..

  • actions_tasks3/case_19_all_image_rotate_features.js
  • actions_tasks3/case_18_filters_functionality.js

@bsekachev
Copy link
Member

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev bsekachev merged commit db6bbba into develop Nov 1, 2022
@SpecLad SpecLad mentioned this pull request Nov 1, 2022
Merged
8 tasks
@sizov-kirill sizov-kirill deleted the sk/fix-import-datumaro branch January 6, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasakova-anastasia yasakova-anastasia yasakova-anastasia left review comments

@zhiltsov-max zhiltsov-max zhiltsov-max left review comments

@SpecLad SpecLad SpecLad approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export and subsequent import causes Error 500 - Datumaro format
5 participants
@sizov-kirill @yasakova-anastasia @bsekachev @SpecLad @zhiltsov-max