Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue: Maximum callstack exceed #4836

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Fixed issue: Maximum callstack exceed #4836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abf2c2c
Fixed issue: Maximum callstack exceed
bsekachev Aug 25, 2022
e20775e
Merge branch 'develop' into bs/fixed_4822
bsekachev Aug 29, 2022
1478e9e
Updated version & changelog
bsekachev Aug 29, 2022
8f39424
Merge branch 'develop' into bs/fixed_4822
bsekachev Aug 30, 2022
3d71213
Merge branch 'develop' into bs/fixed_4822
bsekachev Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ Skeleton (<https://github.com/cvat-ai/cvat/pull/1>), (<https://github.com/opencv
- Creating task with cloud storage data (<https://github.com/cvat-ai/cvat/pull/116>)
- Show empty tasks (<https://github.com/cvat-ai/cvat/pull/100>)
- Fixed project filtration (<https://github.com/opencv/cvat/pull/4878>)
- Maximum callstack exceed when create task with 100000+ files from cloud storage (<https://github.com/opencv/cvat/pull/4836>)

### Security
- TDB
Expand Down
24 changes: 15 additions & 9 deletions cvat-core/src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,8 +1573,8 @@
* @throws {module:API.cvat.exceptions.ArgumentError}
*/
serverFiles: {
get: () => [...data.files.server_files],
set: (serverFiles) => {
get: () => Array.from(data.files.server_files),
set: (serverFiles: string[]) => {
if (!Array.isArray(serverFiles)) {
throw new ArgumentError(
`Value must be an array. But ${typeof serverFiles} has been got.`,
Expand All @@ -1589,7 +1589,9 @@
}
}

Array.prototype.push.apply(data.files.server_files, serverFiles);
for (const file of serverFiles) {
data.files.server_files.push(file);
}
},
},
/**
Expand All @@ -1601,8 +1603,8 @@
* @throws {module:API.cvat.exceptions.ArgumentError}
*/
clientFiles: {
get: () => [...data.files.client_files],
set: (clientFiles) => {
get: () => Array.from(data.files.client_files),
set: (clientFiles: File[]) => {
if (!Array.isArray(clientFiles)) {
throw new ArgumentError(
`Value must be an array. But ${typeof clientFiles} has been got.`,
Expand All @@ -1617,19 +1619,21 @@
}
}

Array.prototype.push.apply(data.files.client_files, clientFiles);
for (const file of clientFiles) {
data.files.client_files.push(file);
}
},
},
/**
* List of files from remote host
* @name remoteFiles
* @type {File[]}
* @type {string[]}
* @memberof module:API.cvat.classes.Task
* @instance
* @throws {module:API.cvat.exceptions.ArgumentError}
*/
remoteFiles: {
get: () => [...data.files.remote_files],
get: () => Array.from(data.files.remote_files),
set: (remoteFiles) => {
if (!Array.isArray(remoteFiles)) {
throw new ArgumentError(
Expand All @@ -1645,7 +1649,9 @@
}
}

Array.prototype.push.apply(data.files.remote_files, remoteFiles);
for (const file of remoteFiles) {
data.files.remote_files.push(file);
}
},
},
/**
Expand Down