Fixes some serverless functions (HRNET, IOG, f-BRS) #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amteusch
force-pushed
the
google_drive_weights
branch
from
12ee918
to
459f36c
Compare
|
@yasakova-anastasia @bsekachev I see some of these changes made it in on another pull request, any way we can get this HRNET change too? |
|
Could you please check HRNet? |
Yes, HRNet is not working. These changes solve this problem |
|
Thank you for the contribution! :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes #4736, and also includes a fix for HRNET from @IuliuNovac in #4900. Some serverless functions (IOG, f-BRS) were downloading weights from Google Drive, but Google Drive changed and weights were not downloading properly, this should address that. Also updates the yaml files for a few serverless functions that had outdated or incompatible versions of python, opencv, etc. There might be a better way to fix these yamls but this is simply how I got them working and figured it's better than nothing.
How has this been tested?
Tested the serverless functions running locally on Ubuntu 20.04.5. They seemed to work fine, which is better than the current state of the repo, but I'm not sure if there is any performance decrease relative to when they worked before.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.