Fixed unstable e2e restore tests #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check |
|
✔️ All checks completed successfully |
|
/check |
|
✔️ All checks completed successfully |
|
@bsekachev Could you look on this fix? |
|
/check |
|
✔️ All checks completed successfully |
bsekachev
approved these changes
Sep 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #4995
The problem with restore tests arises when network runs slow, which can happen from time to time. After backup was uploaded tests were checking for restoring status. If its in progress, server returned
202, if it ended server returned201. When network is fast enough202is returned, and if its slow, backup restore is ended already which leads to201response. Hence we need to make waiting for202response optional.How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.