Fixed shape color not changed #5044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
reviewed
Oct 5, 2022
| @@ -681,9 +681,33 @@ export default class CanvasWrapperComponent extends React.PureComponent<Props> { | |||
|
|
|||
| private updateCanvas(): void { | |||
| const { | |||
| curZLayer, annotations, frameData, canvasInstance, | |||
| curZLayer, annotations, frameData, canvasInstance, colorBy, | |||
There was a problem hiding this comment.
Hi,
My general comment is that shape color management should be solved on cvat-canvas level, not cvat-ui.
|
Could you please try this one? #5045 |
|
I tried this and it worked. As you commented, I think it is right to manage on cvat-canvas than on cvat-ui. It was helpful to me. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Related #4966
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.