Run functional tests for REST API during a build #506
Conversation
.travis.yml
Outdated
| @@ -12,5 +12,6 @@ before_script: | |||
| - docker-compose -f docker-compose.yml -f docker-compose.ci.yml up --build -d | |||
|
|
|||
| script: | |||
| - docker exec -it cvat /bin/bash -c 'tests/node_modules/.bin/karma start tests/karma.conf.js' | |||
| - docker exec -it cvat /bin/bash -c 'python3 manage.py test --settings cvat.settings.testing cvat/apps/engine && | |||
There was a problem hiding this comment.
@EvgenyShashkin , do we really need --settings cvat.settings.testing here? I see that below we specify DJANGO_CONFIGURATION. I hope it should be enough. Also it is not good to close an issue before a PR which fixes it is merged. You can specify in description of PR Resolved #... and it will be closed automatically after the PR is merged. Could you please follow the approach?
Another problem I don't see that travis was run for the patch. Could you please explain why?
|
Resolved #420 |
.travis.yml
Outdated
| @@ -12,5 +12,6 @@ before_script: | |||
| - docker-compose -f docker-compose.yml -f docker-compose.ci.yml up --build -d | |||
|
|
|||
| script: | |||
| - docker exec -it cvat /bin/bash -c 'tests/node_modules/.bin/karma start tests/karma.conf.js' | |||
| - docker exec -it cvat /bin/bash -c 'python3 manage.py test --settings cvat.settings.testing cvat/apps/engine && tests/node_modules/.bin/karma start tests/karma.conf.js' | |||
There was a problem hiding this comment.
@EvgenyShashkin , do we need --settings cvat.settings.testing here?
There was a problem hiding this comment.
@nmanovic , yes, because file testing.py contains functions for working with fakeredis
|
@EvgenyShashkin , please read my comments and fix them. Also please add a message to CHANGELOG.md file that we added running tests. If a test is fail what will we have (just post an example of messages from logs)? |
|
@EvgenyShashkin , OK. I add WIP prefix for the request. I need more information to accept it. Not all questions in the PR were resolved. Let me know if you need more information. Don't hesitate to write your questions into itlab Gitter |
nmanovic
changed the title
nmanovic
changed the title
* develop: (112 commits) fixed attribute processing in auto_annotation (cvat-ai#577) CVAT.js API Tests (cvat-ai#578) Fixed exception in attribute annotation mode (cvat-ai#571) CVAT.js API methods were implemented (cvat-ai#572) Dashboard components basic styles (cvat-ai#574) Handle invalid json labelmap file case correctly during create/update DL model stage. (cvat-ai#573) Upgrade Numpy to avoid Arbitrary Code Execution. Upgrade Django to avoid MitM (cvat-ai#575) Run functional tests for REST API during a build (cvat-ai#506) CVAT.js other implemented API methods and bug fixes (cvat-ai#569) CVAT.js implemented API methods and bug fixes (cvat-ai#564) added in handeling for openvino 2019 (cvat-ai#545) added in command line auto annotation runner (cvat-ai#563) Fixed PDF extractor syntax error (cvat-ai#565) Update README.md added in pdf extractor (cvat-ai#557) Basic dashboard components (cvat-ai#562) Saving of annotations on the server (cvat-ai#561) Code was devided by files (cvat-ai#558) CVAT.js: Save and delete for shapes/tracks/tags (cvat-ai#555) Fixed '=' to '==' for numpy in requirments (cvat-ai#556) ... # Conflicts: # .gitignore
No description provided.