Data validation on client and server #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
changed the title
azhavoro
reviewed
Sep 12, 2018
cvat/apps/engine/annotation.py
Outdated
| for box in path['shapes']: | ||
| if int(box['frame']) < self.start_frame: | ||
| has_boxes_on_prev_segm = True | ||
| if last_box_on_prev_segm is None or int(last_box_on_prev_segm["frame"] < box["frame"]): |
There was a problem hiding this comment.
int(last_box_on_prev_segm["frame"]) < int(box["frame"]) ?
cvat/apps/engine/annotation.py
Outdated
| for poly_shape in path['shapes']: | ||
| if int(poly_shape['frame']) < self.start_frame: | ||
| has_shapes_on_prev_segm = True | ||
| if last_shape_on_prev_segm is None or int(last_shape_on_prev_segm["frame"] < poly_shape["frame"]): |
azhavoro
approved these changes
Sep 12, 2018
nmanovic
pushed a commit
that referenced
this pull request
Sep 19, 2018
* Move function from closure to class method * Bug has been fixed: Failed to execute 'inverse' on 'SVGMatrix': The matrix is not invertible * Performance of frame changing has been increased due to UI containers had detached from DOM before their items were created * Bug has been fixed: Defiant doesn't support dash (-) in xpath nodes (#53) * Data validation on client and server (#51) * Migration files have been added (#59) * Big int migration file has been rewritten with Django syntax (#60) * Some memory leaks have been fixed (#61)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #49
Resolved #50