Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New authentication UI #5181

Merged
merged 50 commits into from
Nov 9, 2022
Merged

New authentication UI #5181

merged 50 commits into from
Nov 9, 2022

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Oct 28, 2022

Dependent on #5147
Resolved #5166

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov changed the title [Dependent] New authentication UI [WIP] New authentication UI Nov 7, 2022
@klakhov klakhov changed the title [WIP] New authentication UI New authentication UI Nov 7, 2022
@klakhov
Copy link
Contributor Author

klakhov commented Nov 7, 2022

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

❌ Some checks failed
📄 See logs here

@klakhov
Copy link
Contributor Author

klakhov commented Nov 8, 2022

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

🚫 Workflows has been canceled
📄 See logs here

@sizov-kirill
Copy link
Contributor

@klakhov there is already not necessary to run full check workflow, all our tests are running in main workflow (as it was before full check)

@bsekachev
Copy link
Member

Input field still tries to escape from the initial position when I entering something, it does not look well IMHO..

example

Please, look also how "Next" button goes out of the form and then returns back

@bsekachev
Copy link
Member

Why can't we have a username with dots? They are allowed in django https://docs.djangoproject.com/en/4.1/ref/contrib/auth/#django.contrib.auth.models.User.username

@klakhov
Copy link
Contributor Author

klakhov commented Nov 8, 2022

@bsekachev I belive It's better now (adjusted size a bit).
jumpingform2

dotinusename

@bsekachev bsekachev merged commit 92ba1ab into develop Nov 9, 2022
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
@bsekachev bsekachev deleted the kl/authentication-ui branch March 1, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Bug: If email the first part contains . during registration, it causes the issue
4 participants