Try to catch / workaround 5215 #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
changed the title
zhiltsov-max
changed the title
nmanovic
approved these changes
Dec 3, 2022
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Fixes cvat-ai#5215 It's not really clear how the error can be obtained, but this PR adds a workaround for the problem. There are 2 possible ways to get the `message` parameter - from an error and from the operation status. - Our status messages are always represented by a string, no any other values is assigned. - rq is trickier here - it receives rq data and [decodes it](https://github.com/rq/rq/blob/master/rq/job.py#L603-L609) if there is an error, but the operations can leave None as the `exc_info` value. Maybe [this issue](rq/rq#1633) is relevant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes #5215
It's not really clear how the error can be obtained, but this PR adds a workaround for the problem. There are 2 possible ways to get the
messageparameter - from an error and from the operation status.Our status messages are always represented by a string, no any other values is assigned.
rq is trickier here - it receives rq data and decodes it if there is an error, but the operations can leave None as the
exc_infovalue. Maybe this issue is relevant here.How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.