Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue 5256, improved 'occluded' visualization #5259

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Fixed issue 5256, improved 'occluded' visualization #5259

merged 5 commits into from
Nov 9, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 8, 2022 •
edited
Loading

Motivation and context

Resolved #5256

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested review from klakhov and removed request for nmanovic and azhavoro November 8, 2022 15:36
@bsekachev bsekachev changed the title [WIP] Fixed issue 5256, improved 'occluded' visualization Fixed issue 5256, improved 'occluded' visualization Nov 8, 2022
klakhov
klakhov reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now dashes apply instantly😄
Also found some inconvinient behavior. When im trying to turn off occluded on one part, its not updated:
skeleton-occluded

cvat-canvas/src/typescript/canvasView.ts Show resolved Hide resolved
@klakhov
Copy link
Contributor

klakhov commented Nov 9, 2022

Also there is red rest_api test, TestTaskUsecases.test_cant_create_task_with_no_data doesn't seem to be related to the patch. @kirill-sizov could you take a look?

@sizov-kirill
Copy link
Contributor

sizov-kirill commented Nov 9, 2022 •
edited
Loading

Also there is red rest_api test, TestTaskUsecases.test_cant_create_task_with_no_data doesn't seem to be related to the patch. @kirill-sizov could you take a look?

Yes, this problem is not related with this PR, we have corresponding issue about it #5215

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

Failed because of:
image

@bsekachev bsekachev merged commit 080755a into develop Nov 9, 2022
@bsekachev bsekachev deleted the bs/fixed_issue_5256 branch November 11, 2022 10:16
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

Assignees

@klakhov klakhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skeleton Track: Hide keypoints does not take effect immediately
3 participants
@bsekachev @klakhov @sizov-kirill