Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UX of user logout #5266

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Improved UX of user logout #5266

merged 5 commits into from
Nov 11, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 9, 2022 •
edited
Loading

Motivation and context

Resolved #5265
Implemented by logging out via a component which saves logs
Also the component has dedicated URL /auth/logout and when a user goes there, the browser suggests to save unsaved changes on annotation view.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from nmanovic as a code owner November 9, 2022 13:18
@bsekachev bsekachev changed the title [WIP] Improved UX of user logout Improved UX of user logout Nov 9, 2022
@bsekachev bsekachev requested review from klakhov and removed request for nmanovic November 9, 2022 13:24
@bsekachev
Copy link
Member Author

@klakhov

Could you look at this minor patch?

@bsekachev bsekachev requested a review from azhavoro as a code owner November 9, 2022 14:19
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member Author

Currently failed because of npm connection error:
image

@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

klakhov
klakhov reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch, works as expected

tests/cypress/integration/actions_users/issue_1810_login_logout.js Show resolved Hide resolved
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

@kirill-sizov

Do you have any ideas about failed REST API test on the server? I didn't touch the server here anyhow.

@sizov-kirill
Copy link
Contributor

@kirill-sizov

Do you have any ideas about failed REST API test on the server? I didn't touch the server here anyhow.

Never seen such an error, need some time to investigate

@bsekachev bsekachev merged commit 6acab03 into develop Nov 11, 2022
@bsekachev bsekachev deleted the bs/fixed_issue_5265 branch November 11, 2022 10:16
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees

@klakhov klakhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX issues when a user logging out from an opened job
3 participants
@bsekachev @sizov-kirill @klakhov