Fix: visibility and ignored information fail to be loaded (MOT dataset format) #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasakova-anastasia
changed the title
SpecLad
requested changes
Nov 10, 2022
| continue | ||
|
|
||
| track_id = ann.attributes.get('track_id') | ||
| occluded = dm.util.cast(ann.attributes.pop('occluded', None), bool) is True |
There was a problem hiding this comment.
bool casting can be too wide - e.g. bool('hello') is True. I'd suggest to compare with the expected value directly, i.e. pop(..., False) is True instead.
| outside=False, | ||
| keyframe=True, | ||
| z_order=ann.z_order, | ||
| frame=frame_number, | ||
| attributes=[], | ||
| attributes=attributes, |
There was a problem hiding this comment.
This assignment might need to take into account the mutable property of an attribute.
There was a problem hiding this comment.
This happens later in the _import_attribute function
SpecLad
approved these changes
Nov 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fix #5231
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.