Allowed to upload .xml and .json annotation files from UI
#5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klakhov
requested review from
azhavoro,
bsekachev and
nmanovic
as code owners
klakhov
force-pushed
the
kl/fix-issue-5274
branch
from
53afc1e
to
965160f
Compare
|
@bsekachev Could you look on this pr? |
bsekachev
reviewed
Nov 30, 2022
cvat-core/src/annotations.ts
Outdated
| '.zip', '.xml', '.json', | ||
| ]; | ||
| if (typeof file === 'string' && !(allowedFileExtensions.some((ext) => file.toLowerCase().endsWith(ext)))) { | ||
| throw new ArgumentError('File must be file instance with eigther ZIP, XML or JSON extension'); |
There was a problem hiding this comment.
Maybe to use allowedFileExtensions list in this message?
cvat-core/src/annotations.ts
Outdated
| 'application/json', | ||
| ]; | ||
| if (file instanceof File && !(allowedMimeTypes.includes(file.type))) { | ||
| throw new ArgumentError('File must be file instance with eigther ZIP, XML or JSON extension'); |
|
Please, look at eslint issues |
|
okay, issues related with core part, I will merge it as is. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #5274
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.