Fix redundant writing of skeleton annotations (CVAT for images) #5387

yasakova-anastasia · 2022-11-30T12:29:10Z

Motivation and context

Fixed #5279

How has this been tested?

Checklist

I submit my changes into the develop branch
I have added a description of my changes into CHANGELOG file
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues (read github docs)
I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

cvat-core/src/annotations-objects.ts

yasakova-anastasia · 2022-12-01T14:34:08Z

@zhiltsov-max, could you please review this PR?

zhiltsov-max · 2022-12-01T17:01:22Z

@yasakova-anastasia, do you think it needs testing?

yasakova-anastasia · 2022-12-01T17:05:53Z

@yasakova-anastasia, do you think it needs testing?

I think no. There are already tests for import/export of annotations with skeletons.

nmanovic · 2022-12-01T19:37:53Z

@yasakova-anastasia, do you think it needs testing?

I think no. There are already tests for import/export of annotations with skeletons.

Could an existing test find the problem?

yasakova-anastasia · 2022-12-01T19:43:32Z

Could an existing test find the problem?

Extra information was written in the annotation, it did not break anything. So I don't think a test is needed here.

nmanovic · 2022-12-01T20:57:02Z

@yasakova-anastasia , I created a task and uploaded 8 images. The task has one skeleton with 3 points. On the first frame I created a track. On the second frame I marked it as outside. As output I got the following:

  <track id="0" label="triangle" source="manual">
    <skeleton frame="0" outside="0" occluded="0" keyframe="1" points="" z_order="0">
    </skeleton>
    <skeleton frame="1" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <skeleton frame="2" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <skeleton frame="3" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <skeleton frame="4" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <skeleton frame="5" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <skeleton frame="6" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <skeleton frame="7" outside="0" occluded="0" keyframe="0" points="" z_order="0">
    </skeleton>
    <track id="0" label="1" source="manual">
      <points frame="0" outside="0" occluded="0" keyframe="1" points="91.30,52.60" z_order="0">
      </points>
      <points frame="1" outside="1" occluded="0" keyframe="1" points="91.30,52.60" z_order="0">
      </points>
    </track>
    <track id="1" label="2" source="manual">
      <points frame="0" outside="0" occluded="0" keyframe="1" points="211.09,47.14" z_order="0">
      </points>
      <points frame="1" outside="1" occluded="0" keyframe="1" points="211.09,47.14" z_order="0">
      </points>
    </track>
    <track id="2" label="3" source="manual">
      <points frame="0" outside="0" occluded="0" keyframe="1" points="190.75,158.98" z_order="0">
      </points>
      <points frame="1" outside="1" occluded="0" keyframe="1" points="190.75,158.98" z_order="0">
      </points>
    </track>
  </track>

At the same time I expected to get something like:

  <track id="0" label="triangle" source="manual">
    <skeleton frame="0" outside="0" occluded="0" keyframe="1" points="" z_order="0">
      <points label="1" outside="0" occluded="0" keyframe="1" points="91.30,52.60" z_order="0"/>
      <points label="2" outside="0" occluded="0" keyframe="1" points="211.09,47.14" z_order="0"/>
      <points label="3" outside="0" occluded="0" keyframe="1" points="190.75,158.98" z_order="0"/>
   </skeleton>
    <skeleton frame="1" outside="1" occluded="0" keyframe="1" points="" z_order="0">
      <points label="1" outside="1" occluded="0" keyframe="1" points="211.09,47.14" z_order="0"/>
      <points label="2" outside="1" occluded="0" keyframe="1" points="91.30,52.60" z_order="0">
      <points label="3" outside="1" occluded="0" keyframe="1" points="190.75,158.98" z_order="0">
    </skeleton>
  </track>

Do you agree?

nmanovic · 2022-12-01T21:10:23Z

Another possible variable which probably also fine (but it has two tracks with the same id):

 <track id="0" label="triangle" type="skeleton">
    <track id="0" label="1" source="manual">
      <points frame="0" outside="0" occluded="0" keyframe="1" points="91.30,52.60" z_order="0"/>
      <points frame="1" outside="1" occluded="0" keyframe="1" points="91.30,52.60" z_order="0"/>
    </track>
    <track id="1" label="2" source="manual">
      <points frame="0" outside="0" occluded="0" keyframe="1" points="211.09,47.14" z_order="0"/>
      <points frame="1" outside="1" occluded="0" keyframe="1" points="211.09,47.14" z_order="0"/>
    </track>
    <track id="2" label="3" source="manual">
      <points frame="0" outside="0" occluded="0" keyframe="1" points="190.75,158.98" z_order="0"/>
      <points frame="1" outside="1" occluded="0" keyframe="1" points="190.75,158.98" z_order="0"/>
    </track>
</track>

nmanovic · 2022-12-01T21:16:22Z

For images I expect something like:

    <skeleton label="triangle" z_order="0">
      <points label="1" occluded="0" source="manual" outside="0" points="91.30,52.60">
      </points>
      <points label="2" occluded="0" source="manual" outside="0" points="211.09,47.14">
      </points>
      <points label="3" occluded="0" source="manual" outside="0" points="190.75,158.98">
      </points>
    </skeleton>

Don't need to have computed attributes for a skeleton itself. What is z_order for a point? points="" looks strange.

erichhhhho · 2022-12-19T05:02:53Z

For images I expect something like:

    <skeleton label="triangle" z_order="0">
      <points label="1" occluded="0" source="manual" outside="0" points="91.30,52.60">
      </points>
      <points label="2" occluded="0" source="manual" outside="0" points="211.09,47.14">
      </points>
      <points label="3" occluded="0" source="manual" outside="0" points="190.75,158.98">
      </points>
    </skeleton>

Don't need to have computed attributes for a skeleton itself. What is z_order for a point? points="" looks strange.

Hi, I just tried the branch ay/extra-anno-in-cvat, it seems the videos xml got fixed alr, but the images xml still got the redundant skeleton track.

yasakova-anastasia · 2022-12-19T07:26:44Z

Hi, I just tried the branch ay/extra-anno-in-cvat, it seems the videos xml got fixed alr, but the images xml still got the redundant skeleton track.

Hi, @erichhhhho
I checked it again and found no problem with CVAT for images. Could you please give an example of this problem?

erichhhhho · 2023-01-04T01:17:28Z

Hi, I just tried the branch ay/extra-anno-in-cvat, it seems the videos xml got fixed alr, but the images xml still got the redundant skeleton track.

Hi, @erichhhhho I checked it again and found no problem with CVAT for images. Could you please give an example of this problem?

Hi @yasakova-anastasia, I checked again also, and there is no issue. Thank you for the fixing!!

site/content/en/docs/manual/advanced/xml_format.md

cvat/apps/dataset_manager/formats/cvat.py

…-ai#5387) Fixed cvat-ai#5279

Fix an issue with writing extra information in annotations

5c104af

yasakova-anastasia requested a review from bsekachev as a code owner November 30, 2022 12:29

bsekachev reviewed Nov 30, 2022

View reviewed changes

cvat-core/src/annotations-objects.ts Outdated Show resolved Hide resolved

cvat-core/src/annotations-objects.ts Outdated Show resolved Hide resolved

yasakova-anastasia added 3 commits November 30, 2022 15:08

Small fix

aaf49af

Update Changelog

43fdd44

Add fixes to the server

8497993

yasakova-anastasia requested review from zhiltsov-max and nmanovic as code owners November 30, 2022 15:59

Resolve conflicts

0112005

Merge branch 'develop' into ay/extra-anno-in-cvat

2a09b91

nmanovic changed the title ~~Fix redundant writing of skeleton annotations (CVAT for images)~~ [WIP] Fix redundant writing of skeleton annotations (CVAT for images) Dec 1, 2022

yasakova-anastasia added 2 commits December 5, 2022 21:45

Fix CVAT for video annotations

f703108

Add fixed for projects

b1ed77d

yasakova-anastasia changed the title ~~[WIP] Fix redundant writing of skeleton annotations (CVAT for images)~~ Fix redundant writing of skeleton annotations (CVAT for images) Dec 8, 2022

yasakova-anastasia added 3 commits December 8, 2022 16:20

Resolve conflicts

cba090f

Update documentation

e6e29ff

Merge branch 'develop' into ay/extra-anno-in-cvat

7a93ac5

tasptz mentioned this pull request Dec 21, 2022

Points missing when exporting tracked skeleton #5497

Closed

Merge branch 'develop' into ay/extra-anno-in-cvat

929fe7f

Merge branch 'develop' into ay/extra-anno-in-cvat

9327791

azhavoro reviewed Feb 8, 2023

View reviewed changes

site/content/en/docs/manual/advanced/xml_format.md Outdated Show resolved Hide resolved

yasakova-anastasia added 4 commits February 8, 2023 14:18

Remove occluded field from skeleton annotation

1e986c0

Merge branch 'develop' into ay/extra-anno-in-cvat

eba10b5

Fix documentation

45fa19b

Resolve conflicts

e4f1249

Marishka17 reviewed Feb 14, 2023

View reviewed changes

cvat/apps/dataset_manager/formats/cvat.py Show resolved Hide resolved

yasakova-anastasia added 2 commits February 14, 2023 08:42

Merge branch 'develop' into ay/extra-anno-in-cvat

5f68cfa

Fix an issue with occluded field

7b3ff12

yasakova-anastasia force-pushed the ay/extra-anno-in-cvat branch from 237d29d to 7b3ff12 Compare February 14, 2023 09:58

Merge branch 'develop' into ay/extra-anno-in-cvat

d6c6d97

Marishka17 approved these changes Feb 14, 2023

View reviewed changes

nmanovic merged commit f52902b into develop Feb 15, 2023

nmanovic deleted the ay/extra-anno-in-cvat branch February 15, 2023 10:44

mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023

Fix redundant writing of skeleton annotations (CVAT for images) (cvat…

1b882e1

…-ai#5387) Fixed cvat-ai#5279

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix redundant writing of skeleton annotations (CVAT for images) #5387

Fix redundant writing of skeleton annotations (CVAT for images) #5387

yasakova-anastasia commented Nov 30, 2022 •

edited

Loading

yasakova-anastasia commented Dec 1, 2022

zhiltsov-max commented Dec 1, 2022

yasakova-anastasia commented Dec 1, 2022

nmanovic commented Dec 1, 2022

yasakova-anastasia commented Dec 1, 2022

nmanovic commented Dec 1, 2022 •

edited

Loading

nmanovic commented Dec 1, 2022 •

edited

Loading

nmanovic commented Dec 1, 2022 •

edited

Loading

erichhhhho commented Dec 19, 2022

yasakova-anastasia commented Dec 19, 2022 •

edited

Loading

erichhhhho commented Jan 4, 2023

Fix redundant writing of skeleton annotations (CVAT for images) #5387

Fix redundant writing of skeleton annotations (CVAT for images) #5387

Conversation

yasakova-anastasia commented Nov 30, 2022 • edited Loading

Motivation and context

How has this been tested?

Checklist

License

yasakova-anastasia commented Dec 1, 2022

zhiltsov-max commented Dec 1, 2022

yasakova-anastasia commented Dec 1, 2022

nmanovic commented Dec 1, 2022

yasakova-anastasia commented Dec 1, 2022

nmanovic commented Dec 1, 2022 • edited Loading

nmanovic commented Dec 1, 2022 • edited Loading

nmanovic commented Dec 1, 2022 • edited Loading

erichhhhho commented Dec 19, 2022

yasakova-anastasia commented Dec 19, 2022 • edited Loading

erichhhhho commented Jan 4, 2023

yasakova-anastasia commented Nov 30, 2022 •

edited

Loading

nmanovic commented Dec 1, 2022 •

edited

Loading

nmanovic commented Dec 1, 2022 •

edited

Loading

nmanovic commented Dec 1, 2022 •

edited

Loading

yasakova-anastasia commented Dec 19, 2022 •

edited

Loading