Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social account authentication tests #5444

Merged
merged 60 commits into from
Jan 12, 2023
Merged

Social account authentication tests #5444

merged 60 commits into from
Jan 12, 2023

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Dec 9, 2022

Motivation and context

Depends on #5349
Related #5432
Added tests for social account authentication functionality: cypress test with dummy auth server

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

❌ Some checks failed
📄 See logs here

@Marishka17
Copy link
Contributor Author

/check

@Marishka17 Marishka17 marked this pull request as ready for review December 9, 2022 15:46
@Marishka17 Marishka17 changed the title Social account authentication tests [Do not merge] Social account authentication tests Jan 11, 2023
Marishka17 and others added 3 commits January 11, 2023 08:54
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
@Marishka17 Marishka17 changed the title [Do not merge] Social account authentication tests Social account authentication tests Jan 11, 2023
cvat/apps/iam/views.py Outdated Show resolved Hide resolved
cvat/apps/iam/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is a great job! Let's revert some changes in iam/views.py file. Also need to move testing files into tests/python/social_auth directory.

@Marishka17 Marishka17 changed the title Social account authentication tests [WIP] Social account authentication tests Jan 12, 2023
@Marishka17 Marishka17 changed the title [WIP] Social account authentication tests [Do not merge] Social account authentication tests Jan 12, 2023
@Marishka17 Marishka17 changed the title [Do not merge] Social account authentication tests Social account authentication tests Jan 12, 2023
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit b00bc65 into develop Jan 12, 2023
@nmanovic nmanovic deleted the mk/social_auth_tests branch January 12, 2023 17:36
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Depends on cvat-ai#5349
Related cvat-ai#5432
Added tests for social account authentication functionality: cypress
test with dummy auth server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants