Grid view and multiple context images supported #5542
Conversation
|
/check |
|
❌ Some checks failed |
nmanovic
changed the title
…nto bs/multiple_context_images
|
/check |
|
❌ Some checks failed |
bsekachev
changed the title
|
/check |
|
❌ Some checks failed |
|
/check |
|
✔️ All checks completed successfully |
There was a problem hiding this comment.
I think for long image names text should not be covered with icons, maybe we can move it to the right and clip it with ellipsis. Maybe adding a tooltip in that case.
I think we should switch places of remove button and move button, having remove button at the first place can lead to accidental image removal
cvat-ui/src/components/annotation-page/canvas/grid-layout/canvas-layout.conf.tsx
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/canvas/grid-layout/canvas-layout.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/canvas/views/context-image/context-image.tsx
Outdated
Show resolved
Hide resolved
tests/cypress/integration/actions_tasks2/case_30_collapse_sidebar_appearance.js
Outdated
Show resolved
Hide resolved
cvat/apps/engine/views.py
Outdated
| zip_file.writestr(f'{name}.jpg', result.tobytes()) | ||
| # response = HttpResponse(wrapper, content_type='application/zip') | ||
| # response['Content-Disposition'] = 'attachment; filename=your_zipfile.zip' | ||
| return HttpResponse(io.BytesIO(zip_buffer.getvalue()), content_type='application/zip') |
There was a problem hiding this comment.
Probably HttpStreamingResponse is better. Let's have HttpResponse here because in other places we also use it. Another idea is to use FileStream (I believe it is possible to use io.BytesIO together with the response type).
| @@ -924,7 +924,7 @@ class FrameMetaSerializer(serializers.Serializer): | |||
| width = serializers.IntegerField() | |||
| height = serializers.IntegerField() | |||
| name = serializers.CharField(max_length=1024) | |||
| has_related_context = serializers.BooleanField() | |||
| related_files = serializers.IntegerField() | |||
There was a problem hiding this comment.
I would prefer to keep here the list of names. But let's keep it as is for now. Need to think twice.
|
|
### Motivation and context <img width="1918" alt="image" src="https://user-images.githubusercontent.com/40690378/210207552-7a7dcb0b-4f0c-4cb6-a030-9522ff68a710.png"> <img width="1920" alt="image" src="https://user-images.githubusercontent.com/40690378/210207577-d05503e8-71d5-4e5c-aecd-03e5a762d7b1.png">
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.