Audit logs #5646
Audit logs #5646
Conversation
azhavoro
force-pushed
the
az/audit_logs
branch
from
6ed389c
to
a6bdde7
Compare
| text: element.innerText, | ||
| classes: element.className, |
There was a problem hiding this comment.
Need to think what kind of information we are going to record about pressed buttons. Maybe need to add descriptive class name to all the buttons. Now not everything has it and it is not always clear what button has been pressed.
| } | ||
|
|
||
| private isEventToBeRecorded(node: HTMLElement, filter: string[]): boolean { | ||
| return filter.some((cssClass: string) => node.classList.contains(cssClass)); |
There was a problem hiding this comment.
For now the implementation is allright, but in the future we probably need to generalize it somehow
| @@ -53,3 +53,5 @@ dnspython==2.2.0 | |||
| setuptools==65.5.1 | |||
| django-health-check==3.17.0 | |||
| psutil==5.9.4 | |||
| clickhouse-connect==0.5.10 | |||
| django-crum==0.7.9 | |||
There was a problem hiding this comment.
The app isn't supported for 2 years already: https://github.com/ninemoreminutes/django-crum
| task_id = serializers.IntegerField(required=False, allow_null=True) | ||
| job_id = serializers.IntegerField(required=False, allow_null=True) | ||
| user_id = serializers.IntegerField(required=False, allow_null=True) | ||
| org_id = serializers.IntegerField(required=False, allow_null=True) |
bsekachev
force-pushed
the
az/audit_logs
branch
from
f243abe
to
6ddfbf2
Compare
cvat/apps/events/export.py
Outdated
| writer.writerows(result.result_rows) | ||
|
|
||
| archive_ctime = os.path.getctime(output_filename) | ||
| scheduler = django_rq.get_scheduler(settings.CVAT_QUEUES.IMPORT_DATA.value) |
| @@ -217,6 +218,7 @@ def add_ssh_keys(): | |||
| # FIXME | |||
| # 'corsheaders.middleware.CorsPostCsrfMiddleware', | |||
| 'django.contrib.auth.middleware.AuthenticationMiddleware', | |||
| 'crum.CurrentRequestUserMiddleware', | |||
There was a problem hiding this comment.
We will need to remove the extension. It isn't well supported. Let's think how to do that.
| return get_current_user() | ||
|
|
||
| def user_id(instance): | ||
| current_user = _get_current_user(instance) |
There was a problem hiding this comment.
Why do we need to call _get_current_user? We handle a request. The request has an authentication user. Why should we get a user from job.segment.task.owner?
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.