-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix /api/tasks leads to 500 server error #5700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check anything in the existing DB or add a migration to fix existing labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @transaction.atomic
to the update_label()
too.
Added. I noticed that if the project creation fails with a unique labels error, the project is still created (without labels). I'm not sure this is correct. I think in this case the project should not be created. So I suggest adding |
This looks like the issue (#5750). Yes, this definitely looks invalid to me. I agree, we should add it, and also check if we can benefit from using |
I added |
- Fixed re-deleting of skeleton sublabels (attempt to remove already removed sublabels) ![Screenshot from 2023-02-13 10-00-03](https://user-images.githubusercontent.com/49231913/218693868-0afcde6a-935a-4d3f-bfa4-c1793a367f90.png) - Updated Label model (added `project` to `unique_together`) - Added migration to remove or rename wrong labels
Motivation and context
project
tounique_together
)How has this been tested?
REST API tests
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.