-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK: Add organization support to the high-level layer #5718
Conversation
ModelListMixin[Organization], | ||
ModelRetrieveMixin[Organization], | ||
): | ||
_entity_type = Organization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it will be reasonable to add invitations and memberships as well, because it's quite hard to work with orgs without this. I think, just adding the bases with no extra methods is enough for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair point. I'll take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out, dealing with invitations is tricky, because they're identified by key instead of ID, which breaks some assumptions in the model mixins. I'll try to solve it, but maybe we can postpone that until the next PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds reasonable.
Note: I renamed |
"Current" seems redundant, while "slug" gives a hint as to the data type expected.
This is the CLI equivalent of #5718.
This consists of two parts: * API to work with organizations; * API to work with other resources in the context of an organization.
This consists of two parts:
Motivation and context
How has this been tested?
SDK unit tests.
Checklist
develop
branch[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.