Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task progress bar improvement #5723

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Task progress bar improvement #5723

merged 12 commits into from
Aug 15, 2023

Conversation

PMazarovich
Copy link
Contributor

Motivation and context

There is no way to know it is in validation except going inside the task itself. It can be tedious, just to check the status.
With this improvement summary of job stages is revealed on task itself.

How has this been tested?

It was tested manually

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

Example:
2023-02-17_11-36

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Feb 17, 2023 •
edited
Loading

Hi, could you please check with the latest develop? This may be broken, because server responses about jobs were changed recently.

@PMazarovich
Copy link
Contributor Author

@zhiltsov-max Hello, done.
It still works

@bsekachev bsekachev self-assigned this Feb 17, 2023
@nmanovic
Copy link
Contributor

@PMazarovich , could you please resolve the conflicts? Also, we have merged a big PR with REST API changes. Could you please check that your logic works?

@bsekachev
Copy link
Member

@zhiltsov-max

Server response does not have information about jobs in validation stage.
Can we add it?

image

@bsekachev bsekachev changed the title Task progress bar improvement [WIP] Task progress bar improvement Feb 23, 2023
@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Feb 23, 2023 •
edited
Loading

@bsekachev, sure. Probably, we need to decide what we really want to display here, because job STAGE and STATE are orthogonal, and completed is a state, while validation is a stage.

@zhiltsov-max zhiltsov-max mentioned this pull request Feb 23, 2023
Merged
7 tasks
@PMazarovich
Copy link
Contributor Author

@zhiltsov-max @nmanovic @bsekachev ,Hello!
Should I improve this PR some way so it will be merged?

@zhiltsov-max
Copy link
Contributor

@PMazarovich, the PR is ok, please wait till #5761 is merged.

@PMazarovich
Copy link
Contributor Author

@zhiltsov-max ok, thanks for the info

@zhiltsov-max
Copy link
Contributor

@PMazarovich, please update the PR.

@PMazarovich
Copy link
Contributor Author

@zhiltsov-max done

@zhiltsov-max
Copy link
Contributor

@bsekachev, could you review please?

@bsekachev bsekachev changed the title [WIP] Task progress bar improvement Task progress bar improvement Aug 9, 2023
@bsekachev
Copy link
Member

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member

image

@bsekachev bsekachev merged commit d3d4feb into cvat-ai:develop Aug 15, 2023
33 of 34 checks passed
@azhavoro azhavoro mentioned this pull request Aug 25, 2023
Merged
jonybekov pushed a commit to tezzro/cvat that referenced this pull request Sep 6, 2023
@PMazarovich @bsekachev @jonybekov
Task progress bar improvement (cvat-ai#5723)
11a9064 
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
There is no way to know it is in validation except going inside the task
itself. It can be tedious, just to check the status.
With this improvement summary of job stages is revealed on task itself.

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
It was tested manually

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

Example:

![2023-02-17_11-36](https://user-images.githubusercontent.com/57707673/219599239-865458a9-daaf-4e72-85cc-6c1652086c4b.png)



### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.

---------

Co-authored-by: Boris Sekachev <boris@cvat.ai>
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
@PMazarovich @bsekachev @mikhail-treskin
Task progress bar improvement (cvat-ai#5723)
bb08fa7 
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
There is no way to know it is in validation except going inside the task
itself. It can be tedious, just to check the status.
With this improvement summary of job stages is revealed on task itself.

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
It was tested manually

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

Example:

![2023-02-17_11-36](https://user-images.githubusercontent.com/57707673/219599239-865458a9-daaf-4e72-85cc-6c1652086c4b.png)



### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.

---------

Co-authored-by: Boris Sekachev <boris@cvat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev approved these changes

@Marishka17 Marishka17 Awaiting requested review from Marishka17

@mdacoca mdacoca Awaiting requested review from mdacoca

Assignees

@bsekachev bsekachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PMazarovich @zhiltsov-max @nmanovic @bsekachev