Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK documentation problems #5903

Merged
merged 20 commits into from
Mar 29, 2023
Merged

Fix SDK documentation problems #5903

merged 20 commits into from
Mar 29, 2023

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Mar 22, 2023

Motivation and context

Resolves #5871
Related: #5847, #5814

This PR makes SDK examples valid Python code and adds some missing info.

  • Fixed incorrect method names in examples
  • Added missing api_client. use in method examples
  • Fixed invalid return types in examples
  • Fixed imports in examples
  • Added notes about binary files in low-level API, extra method args and returned values
  • Removed html escapes from method and field descriptions
  • Changed function signatures to be closer to the most popular variants

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Sorry, something went wrong.

@zhiltsov-max zhiltsov-max requested a review from nmanovic as a code owner March 22, 2023 11:08
@zhiltsov-max zhiltsov-max requested a review from SpecLad March 22, 2023 11:09
@zhiltsov-max zhiltsov-max changed the title Fix SDK documentation problems [WIP] Fix SDK documentation problems Mar 22, 2023

Verified

This commit was signed with the committer’s verified signature.
AnaisUrlichs Anais Urlichs
@zhiltsov-max zhiltsov-max changed the title [WIP] Fix SDK documentation problems Fix SDK documentation problems Mar 22, 2023
@zhiltsov-max
Copy link
Contributor Author

I've extended the return type info and info about extra parameters.

zhiltsov-max and others added 2 commits March 23, 2023 14:44
Co-authored-by: Roman Donchenko <roman@cvat.ai>
@SpecLad SpecLad merged commit a9e8225 into develop Mar 29, 2023
@SpecLad SpecLad deleted the zm/fix-docs branch March 29, 2023 11:20
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Resolves cvat-ai#5871
Related: cvat-ai#5847,
cvat-ai#5814

This PR makes SDK examples valid Python code and adds some missing info.

- Fixed incorrect method names in examples
- Added missing `api_client.` use in method examples
- Fixed invalid return types in examples
- Fixed imports in examples
- Added notes about binary files in low-level API, extra method args and
returned values
- Removed html escapes from method and field descriptions
- Changed function signatures to be closer to the most popular variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid low-level api examples are generated in the docs
3 participants