Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webhooks #5916

Merged
merged 38 commits into from
Apr 7, 2023
Merged

Refactor webhooks #5916

merged 38 commits into from
Apr 7, 2023

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented Mar 23, 2023 •
edited
Loading

Motivation and context

This PR fixes the following problems:

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

This was linked to issues Mar 23, 2023
Webhook URL fails (too long) #5767
Closed
[Bug][SDK] Cannot setup webhook if org_id is not sent. #5857
Closed
@sizov-kirill sizov-kirill removed a link to an issue Mar 23, 2023
Webhook URL fails (too long) #5767
Closed
2 tasks
@sizov-kirill sizov-kirill linked an issue Mar 23, 2023 that may be closed by this pull request
Webhooks: delete:project and delete:organization events are not reported #5631
Closed
@sizov-kirill sizov-kirill changed the title [WIP] Refactor webhooks Refactor webhooks Mar 23, 2023
@sizov-kirill sizov-kirill removed a link to an issue Mar 23, 2023
[Bug][SDK] Cannot setup webhook if org_id is not sent. #5857
Closed
2 tasks
@sizov-kirill sizov-kirill changed the title Refactor webhooks [WIP] Refactor webhooks Mar 24, 2023
@sizov-kirill sizov-kirill changed the title [WIP] Refactor webhooks Refactor webhooks Mar 24, 2023
@klakhov
Copy link
Contributor

klakhov commented Mar 27, 2023

E2E tests fail because of broken project deletion, if I try to delete non-empty project then it appears as empty.
Needs fix.

@sizov-kirill
Copy link
Contributor Author

E2E tests fail because of broken project deletion, if I try to delete non-empty project then it appears as empty. Needs fix.

@klakhov Thank you so much, for your investigation. I will fix it

SpecLad
SpecLad reviewed Apr 3, 2023
View reviewed changes
cvat/apps/events/handlers.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/views.py Outdated Show resolved Hide resolved
tests/python/shared/fixtures/init.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
SpecLad
SpecLad reviewed Apr 5, 2023
View reviewed changes
cvat/apps/webhooks/event_type.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/signals.py Outdated Show resolved Hide resolved
cvat/apps/webhooks/event_type.py Outdated Show resolved Hide resolved
@SpecLad SpecLad merged commit 7cff867 into develop Apr 7, 2023
@SpecLad SpecLad deleted the sk/refactor-webhooks branch April 7, 2023 09:20
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
@nmanovic @yasakova-anastasia
@SpecLad @mikhail-treskin
Refactor webhooks (cvat-ai#5916)
e7a78f9 
This PR fixes the following problems:
- cvat-ai#5631
- This will allow webhooks to be sent not only when an explicit request
has been sent to the server.

Co-authored-by: Nikita Manovich <nikita@cvat.ai>
Co-authored-by: yasakova-anastasia <anastasia@cvat.ai>
Co-authored-by: Roman Donchenko <roman@cvat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic left review comments

@SpecLad SpecLad SpecLad approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@Marishka17 Marishka17 Awaiting requested review from Marishka17 Marishka17 is a code owner

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhooks: delete:project and delete:organization events are not reported
5 participants
@sizov-kirill @klakhov @SpecLad @nmanovic @yasakova-anastasia