Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python dependency versions #5938

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Mar 27, 2023

Motivation and context

While testing the development environment setup instructions in #5889, I found that some of the Python packages have problems with installing on newer Linuxes. Fortunately, most such problems can be resolved by bumping the versions:

  • psycopg2-binary to enable support for Python 3.10+ (the current version does work with these Pythons, but it doesn't have prebuilt wheels for them).

  • python-ldap to enable support for OpenLDAP 2.5+ (on systems that don't include a compatibility libldap_r.so symlink, like Arch).

How has this been tested?

pip install in a Docker container of Arch Linux and on Ubuntu 22.04.

Checklist

  • I submit my changes into the develop branch
  • [ ] I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

* `psycopg2-binary` to enable support for Python 3.10+ (the current version
  does work with these Pythons, but it doesn't have prebuilt wheels for
  them).

* `python-ldap` to enable support for OpenLDAP 2.5+ (on systems that don't
  include a compatibility `libldap_r.so` symlink, like Arch).
@SpecLad SpecLad requested a review from nmanovic as a code owner March 27, 2023 09:22
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit c156dc6 into cvat-ai:develop Mar 27, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
While testing the development environment setup instructions in cvat-ai#5889, I
found that some of the Python packages have problems with installing on
newer Linuxes. Fortunately, most such problems can be resolved by
bumping the versions:

* `psycopg2-binary` to enable support for Python 3.10+ (the current
version does work with these Pythons, but it doesn't have prebuilt
wheels for them).

* `python-ldap` to enable support for OpenLDAP 2.5+ (on systems that
don't include a compatibility `libldap_r.so` symlink, like Arch).
@SpecLad SpecLad deleted the bump-deps branch July 20, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants