Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tried to optimize annotation fetching #5974

Merged
merged 21 commits into from
Apr 5, 2023
Merged

Tried to optimize annotation fetching #5974

merged 21 commits into from
Apr 5, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Apr 4, 2023 •
edited
Loading

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

bsekachev
bsekachev commented Apr 4, 2023
View reviewed changes
cvat/apps/engine/mixins.py Outdated Show resolved Hide resolved
bsekachev
bsekachev commented Apr 5, 2023
View reviewed changes
cvat/apps/dataset_manager/task.py Outdated Show resolved Hide resolved
cvat/apps/dataset_manager/task.py Outdated Show resolved Hide resolved
@nmanovic
Copy link
Contributor

nmanovic commented Apr 5, 2023

@bsekachev , can we pack all your changes into https://www.django-rest-framework.org/api-guide/serializers/#baseserializer? Inherit LabeledShapeSeiralizer from BaseSerializer and implement all logic here? Will it work?

@zhiltsov-max zhiltsov-max mentioned this pull request Apr 5, 2023
Closed
@nmanovic nmanovic requested a review from SpecLad April 5, 2023 12:44
SpecLad
SpecLad reviewed Apr 5, 2023
View reviewed changes
cvat/apps/engine/backup.py Outdated Show resolved Hide resolved
cvat/apps/engine/mixins.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/dataset_manager/task.py Outdated Show resolved Hide resolved
SpecLad
SpecLad reviewed Apr 5, 2023
View reviewed changes
cvat/apps/engine/serializers.py Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
@SpecLad
Copy link
Contributor

SpecLad commented Apr 5, 2023

BTW, it seems like this warrants a changelog entry.

@nmanovic nmanovic merged commit 791d93f into develop Apr 5, 2023
@nmanovic nmanovic deleted the bs/opt branch April 5, 2023 16:53
nmanovic pushed a commit that referenced this pull request Apr 5, 2023
@bsekachev @nmanovic
Tried to optimize annotation fetching (#5974)
3216bd3
@nmanovic nmanovic mentioned this pull request Apr 5, 2023
Merged
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
@bsekachev @mikhail-treskin
Tried to optimize annotation fetching (cvat-ai#5974)
9c5da46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecLad SpecLad SpecLad left review comments

@zhiltsov-max zhiltsov-max Awaiting requested review from zhiltsov-max zhiltsov-max is a code owner

@Marishka17 Marishka17 Awaiting requested review from Marishka17 Marishka17 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsekachev @nmanovic @SpecLad