Fix write once fields #5975
Merged
Fix write once fields #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
requested review from
azhavoro,
SpecLad and
Marishka17
as code owners
zhiltsov-max
force-pushed
the
zm/fix-write-once-mixin
branch
from
f6626c8 to
8eac590
Compare
zhiltsov-max
force-pushed
the
zm/fix-write-once-mixin
branch
from
8eac590 to
bd51e56
Compare
SpecLad
reviewed
Apr 5, 2023
SpecLad
approved these changes
Apr 6, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
This PR fixes a problem with WriteOnceSerializer that it affected only the fields declared in the `Meta.fields`, while the manually declared fields were left unaffected. This PR also fixes several issues with invalid field declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR fixes a problem with WriteOnceSerializer that it affected only the fields declared in the
Meta.fields, while the manually declared fields were left unaffected. This PR also fixes several issues with invalid field declarations.How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.