Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor server api tests and dataset_manifest #5997

Merged
merged 9 commits into from
Apr 17, 2023
Merged

Refactor server api tests and dataset_manifest #5997

merged 9 commits into from
Apr 17, 2023

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Apr 10, 2023 •
edited
Loading

Motivation and context

Extracted from #5083

  • Fixed test data placement in tests
  • Fixed cache cleaning in tests
  • Refactored server API tests and dataset_manifest
  • Added more tests

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max requested a review from SpecLad April 10, 2023 10:39
@zhiltsov-max zhiltsov-max force-pushed the zm/refactor-server-api-tests branch from 1c951c4 to 45d5e2c Compare April 10, 2023 10:43
SpecLad
SpecLad reviewed Apr 12, 2023
View reviewed changes
cvat/apps/engine/tests/utils.py Show resolved Hide resolved
cvat/apps/engine/tests/utils.py Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/utils.py Outdated Show resolved Hide resolved
cvat/apps/engine/task.py Outdated Show resolved Hide resolved
@zhiltsov-max zhiltsov-max changed the title Refactor tests and fix video saving Refactor tests and dataset_manifest Apr 13, 2023
@zhiltsov-max zhiltsov-max changed the title Refactor tests and dataset_manifest Refactor server api tests and dataset_manifest Apr 13, 2023
zhiltsov-max and others added 2 commits April 14, 2023 20:58
@zhiltsov-max @SpecLad
Update cvat/apps/engine/tests/test_rest_api.py
55764db 
Co-authored-by: Roman Donchenko <roman@cvat.ai>
@zhiltsov-max
Fix names
79221cb
@SpecLad SpecLad merged commit ad534b2 into develop Apr 17, 2023
@SpecLad SpecLad deleted the zm/refactor-server-api-tests branch April 17, 2023 15:26
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
@zhiltsov-max @mikhail-treskin
Refactor server api tests and dataset_manifest (cvat-ai#5997)
00701bb 
Extracted from cvat-ai#5083 

- Fixed test data placement in tests
- Fixed cache cleaning in tests
- Refactored server API tests and dataset_manifest
- Added more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecLad SpecLad SpecLad approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@Marishka17 Marishka17 Awaiting requested review from Marishka17 Marishka17 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiltsov-max @SpecLad