Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tus loading if multiple apache processes are used #6006

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

azhavoro
Copy link
Contributor

Motivation and context

How has this been tested?

Manually by set --processes 3 for mod_wsgi settings

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@nmanovic
Copy link
Contributor

@azhavoro , need to add a line into CHANGELOG. Do we have a test for TUS upload feature?

@azhavoro azhavoro requested a review from mdacoca as a code owner April 12, 2023 09:18
@azhavoro
Copy link
Contributor Author

@azhavoro , need to add a line into CHANGELOG. Do we have a test for TUS upload feature?

We have tus test
https://github.com/opencv/cvat/blob/develop/tests/cypress/e2e/actions_tasks3/case_112_tus_upload.js

@azhavoro azhavoro requested a review from klakhov April 12, 2023 09:53
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one failed test, but it looks like its unstable test. It failed in one of my pr's too.

cvat/apps/engine/mixins.py Outdated Show resolved Hide resolved
cvat/apps/engine/mixins.py Show resolved Hide resolved
@nmanovic nmanovic merged commit 1c753d5 into develop Apr 13, 2023
@nmanovic nmanovic deleted the az/fix_tus_upload branch April 13, 2023 12:44
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants