Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honey pot UI #6039

Merged
merged 362 commits into from
Jun 26, 2023
Merged

Honey pot UI #6039

merged 362 commits into from
Jun 26, 2023

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Apr 18, 2023

Motivation and context

  • Added UI for the Honey Pot feature

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

Information about comments

  • Fixed aligns of preview and assignee on task page
  • Added margin in the end of job list on task page
  • Solved/Unsolved issues for Job are kept on place, we can think about removing them in PR with analytics page
    image
  • Copy Job list button was restored to it's place
  • Added borders and border highlight like on task card for job card
  • Changed "0%" to "<1%"
    image
  • Submit and Submit and Open button. I think we should keep those buttons for consistency. In any case user can decide by himself what he wants, just create and go back or immediately go to GT job
  • About GT job issues and participating in computing completion progress
    These jobs still have to be annotated and reviewed by someone in the annotation team, it makes sense to treat their progress equally with other jobs.
  • Space in submit form.
    Personally, I think without it, form looks too short and page becomes empty.
  • Frame intercesction (as all data on Quality page) is extracted from Quality report, so currently we wont show it immidiately
  • Tracks are now shown only on frames included in GT job
  • Object menu in object sidebar is removed for GT annotation
  • Sorting for conflcits/quality is fixed
  • Frame intersection N/A and no ability to download the report means the report doesn't exist yet. We need to wait for it to be computed
  • With fixed problem with tracks, there won't be any annotations on jobs with 0% intersection
  • 2d cuboids and tags wont supported in this version
  • Automatically go to the next frame in tag annotation mode
  • Find empty frame navigation in GT job
  • Delete frame in GT job
    Currently deleted frames are marked for a task, so deleting frame in GT deletes it everywhere. It really doesn't make sence to support deleting frames in GT jobs, So lets disable that option for now
  • [ ] Broken top margin in the frame filter configuration dialog in the annotation page

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

cvat/schema.yml Outdated Show resolved Hide resolved
cvat/schema.yml Outdated Show resolved Hide resolved
cvat/schema.yml Outdated Show resolved Hide resolved
cvat/schema.yml Outdated Show resolved Hide resolved
cvat/schema.yml Outdated Show resolved Hide resolved
cvat/schema.yml Outdated Show resolved Hide resolved
@zhiltsov-max zhiltsov-max changed the title [WIP] Honey pot - prototype [WIP] Honey pot May 4, 2023
.vscode/launch.json Outdated Show resolved Hide resolved
@bsekachev
Copy link
Member

@klakhov

Submit and Submit and Open button. I think we should keep those buttons for consistency. In any case user can decide by himself what he wants, just create and go back or immediately go to GT job

There is no reason to stay on "Create GT job" page after GT job is already created because several GT jobs can not be created.
Two options I see: open GT job immediately, return to analytics page.

cvat-core/src/quality-settings.ts Outdated Show resolved Hide resolved
cvat-core/src/quality-settings.ts Outdated Show resolved Hide resolved
cvat-core/src/server-proxy.ts Outdated Show resolved Hide resolved
cvat-core/src/server-proxy.ts Outdated Show resolved Hide resolved
@klakhov
Copy link
Contributor

klakhov commented Jun 23, 2023

@bsekachev

There is no reason to stay on "Create GT job" page after GT job is already created because several GT jobs can not be created. Two options I see: open GT job immediately, return to analytics page.

Ok, I see. Let's stick to the first option

@bsekachev
Copy link
Member

Okay, let's solve conflicts wait for Andrey review and I believe we can merge it

@zhiltsov-max
Copy link
Contributor Author

zhiltsov-max commented Jun 23, 2023

  • It seems the report computation time info is missing (it was under the downloading button)
    image

  • Job actions menu needs to be fixed: the 3 to "Go To ..." buttons have no use outside the annotation window, probably need to add the black border around the menu
    image

  • Job frame filter has invalid top margin (it's a regression against develop)
    image

@klakhov
Copy link
Contributor

klakhov commented Jun 23, 2023

[x] It seems the report computation time info is missing (it was under the downloading button)

Fixed

[ ] Job actions menu needs to be fixed: the 3 to "Go To ..." buttons have no use outside the annotation window, probably need to add the black border around the menu

This menu is mutual for Jobs cards(on task and jobs pages), those buttons are used on Jobs Page mostly. I dont think we need 2 different menus

[x] Job frame filter has invalid top margin (it's a regression against develop)

Fixed

@azhavoro azhavoro self-requested a review June 23, 2023 09:31
@zhiltsov-max
Copy link
Contributor Author

This menu is mutual for Jobs cards(on task and jobs pages), those buttons are used on Jobs Page mostly. I dont think we need 2 different menus

Ok, but job menus on the task page have the same problem - the "Go To" buttons are not needed there.

@klakhov klakhov merged commit 8590e90 into develop Jun 26, 2023
32 of 34 checks passed
@klakhov klakhov deleted the zm/gt-jobs branch June 26, 2023 09:58
@azhavoro azhavoro mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants