Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: build PyAV and its dependencies in a separate stage #6054

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Apr 20, 2023

Motivation and context

This way, it can be done in parallel with pip fetching all other packages in the main build stage. In practice, I find that the build of PyAV finishes before pip is done downloading, so we basically get it done for free (in terms of time).

With this change, I measured a build time of 9:09 (starting from scratch).

How has this been tested?

Not a whole lot; I just ran python manage.py in the container as a sanity check.

Checklist

  • I submit my changes into the develop branch
  • [ ] I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

This way, it can be done in parallel with pip fetching all other packages in
the main build stage. In practice, I find that the build of PyAV finishes
before pip is done downloading, so we basically get it done for free (in
terms of time).

With this change, I measured a build time of 9:09 (starting from scratch).
@SpecLad SpecLad requested a review from azhavoro as a code owner April 20, 2023 13:51
@nmanovic nmanovic merged commit c657c82 into cvat-ai:develop Apr 21, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
…-ai#6054)

This way, it can be done in parallel with pip fetching all other
packages in the main build stage. In practice, I find that the build of
PyAV finishes before pip is done downloading, so we basically get it
done for free (in terms of time).

With this change, I measured a build time of 9:09 (starting from
scratch).
@SpecLad SpecLad deleted the docker-build-opt branch July 20, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants