Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default TUS chunk size from 100 to 2 MB #6058

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

azhavoro
Copy link
Contributor

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@nmanovic
Copy link
Contributor

@azhavoro , Great patch. Need to add a comment and a line into CHANGELOG.md. Thus in the future, it will prevent us from increasing the value.

@azhavoro azhavoro requested a review from mdacoca as a code owner April 24, 2023 09:29
@azhavoro
Copy link
Contributor Author

@azhavoro , Great patch. Need to add a comment and a line into CHANGELOG.md. Thus in the future, it will prevent us from increasing the value.

Done

@azhavoro
Copy link
Contributor Author

@nmanovic Do you have other comments?

@nmanovic nmanovic merged commit d3d5f9b into develop Apr 24, 2023
@nmanovic nmanovic deleted the az/tus_chunk_size branch April 24, 2023 16:48
@azhavoro azhavoro mentioned this pull request Apr 24, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants