Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to frontend helm template. #6163

Merged
merged 2 commits into from
May 26, 2023

Conversation

senthilkumarkj
Copy link
Contributor

This is similar to annotations in backend template at https://github.com/tidaltech/cvat/blob/develop/helm-chart/templates/cvat_backend/service.yml#L10-L13

Motivation and context

To enable setting annotations to frontend service similar to backend service. Closes #6161

How has this been tested?

I've tested this in my k8s setup.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@senthilkumarkj senthilkumarkj marked this pull request as ready for review May 18, 2023 08:33
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senthilkumarkj , Thank you for the contribution!

@nmanovic nmanovic merged commit 23e5998 into cvat-ai:develop May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s service annotations is missing in cvat_frontend service.yml helm chart
3 participants