Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments for PR 5892 #6206

Merged
merged 23 commits into from
May 31, 2023
Merged

Fix comments for PR 5892 #6206

merged 23 commits into from
May 31, 2023

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented May 29, 2023

Motivation and context

Applied comments:

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max
Copy link
Contributor

Probably, it makes sense to cherry-pick this commit, removing remaining org_id uses in tests: 35d1918

@sizov-kirill sizov-kirill changed the title [WIP] Fix comments for PR 5892 Fix comments for PR 5892 May 29, 2023
@sizov-kirill sizov-kirill requested review from zhiltsov-max and removed request for SpecLad, azhavoro and Marishka17 May 30, 2023 09:01
@nmanovic nmanovic merged commit 2584b96 into develop May 31, 2023
@nmanovic nmanovic deleted the sk/fix-comments-for-pr-5892 branch May 31, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants