Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while enabling SAM on CPU #6249

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Conversation

pbarsic
Copy link
Contributor

@pbarsic pbarsic commented Jun 5, 2023

This PR solves issue #6247 "Error while enabling SAM on CPU".

It looks like the --file argument to nuctl deploy was inadvertently removed in the most recent release. This causes the process to fail with **Error - Function name cannot be empty. I was able to reproduce this error on my own system.

Motivation and context

This change fixes a minor error.

How has this been tested?

I tested this by reproducing the bug with the command from the cvat/components directory:

nuctl deploy --project-name cvat --path "./serverless/pytorch/foolwood/siammask/nuclio" --platform local

I then edited the deploy_cpu.sh file, executed the same command, and completed a successful deployment, which I verified with nuctl get functions.

Checklist

  • I submit my changes into the develop branch
  • [ ] I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@pbarsic pbarsic requested a review from azhavoro as a code owner June 5, 2023 23:50
@bsekachev
Copy link
Member

CVAT uses fixed release of nuclio, not the latest one.

Copy link
Contributor

@SpecLad SpecLad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is somewhat redundant, as the issue should resolve itself with Nuclio 1.11.21, but there's no harm in adding it. Just one minor request...

serverless/deploy_cpu.sh Outdated Show resolved Hide resolved
@SpecLad SpecLad merged commit 7181946 into cvat-ai:develop Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants