Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin action for easy deactivation of users #6314

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

pktiuk
Copy link
Contributor

@pktiuk pktiuk commented Jun 14, 2023

Minor quality of life improvement which helps managing status of users.

Motivation and context

I find this change very useful in my organization, so maybe upstream will also find it useful. :)

image

How has this been tested?

Built and launched an instance with this change

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
    - [ ] I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@pktiuk pktiuk marked this pull request as ready for review June 14, 2023 08:56
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #6314 (a761c3c) into develop (2896bec) will decrease coverage by 2.08%.
The diff coverage is 71.42%.

❗ Current head a761c3c differs from pull request most recent head dc01e36. Consider uploading reports for the commit dc01e36 to get more accurate results

@@             Coverage Diff             @@
##           develop    #6314      +/-   ##
===========================================
- Coverage    81.76%   79.69%   -2.08%     
===========================================
  Files          337      320      -17     
  Lines        38525    37247    -1278     
  Branches      3547     6744    +3197     
===========================================
- Hits         31501    29683    -1818     
- Misses        7024     7286     +262     
- Partials         0      278     +278     
Components Coverage Δ
cvat-ui 77.09% <ø> (+1.86%) ⬆️
cvat-server 82.04% <71.42%> (-5.77%) ⬇️

@nmanovic nmanovic added the Easy to fix The issue is easy to fix and probably it will be release in a next minor release label Sep 5, 2023
Copy link
Contributor

@Marishka17 Marishka17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 705db7b into cvat-ai:develop Sep 11, 2023
31 checks passed
@pktiuk pktiuk deleted the add_admin_action branch September 11, 2023 13:58
@azhavoro azhavoro mentioned this pull request Sep 12, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Minor quality of life improvement which helps managing status of users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants