Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize DB requests #6340

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Optimize DB requests #6340

merged 4 commits into from
Jun 20, 2023

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 19, 2023

Motivation and context

Optimizes several DB request memory issues, introduced in #6204

  • Optimized memory use in job annotation retrieval
  • Optimized migration

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max requested review from azhavoro and removed request for Marishka17 June 19, 2023 15:43
@zhiltsov-max zhiltsov-max changed the title [WIP] Optimize annotations request Optimize DB requests Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #6340 (1b2e8db) into develop (9db68a3) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #6340      +/-   ##
===========================================
- Coverage    79.76%   79.76%   -0.01%     
===========================================
  Files          321      321              
  Lines        37323    37329       +6     
  Branches      6753     6756       +3     
===========================================
+ Hits         29772    29774       +2     
- Misses        7283     7287       +4     
  Partials       268      268              
Components Coverage Δ
cvat-ui 77.11% <ø> (-0.02%) ⬇️
cvat-server 82.15% <66.66%> (+<0.01%) ⬆️

@azhavoro
Copy link
Contributor

@zhiltsov-max Could you add a note to the changelog please?

@azhavoro azhavoro merged commit 97eb6a9 into develop Jun 20, 2023
azhavoro pushed a commit that referenced this pull request Jun 20, 2023
Optimizes several DB request memory issues, introduced in #6204

- Optimized memory use in job annotation retrieval
- Optimized migration
@bsekachev bsekachev deleted the zm/optimize-annotations-requests branch June 20, 2023 11:29
@azhavoro azhavoro mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants