Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API schema for the owner field #6343

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Fix API schema for the owner field #6343

merged 4 commits into from
Jun 20, 2023

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

The owner field can be null if the user was removed after the object had been created, but API schema doesn't support this. This PR fixes the schema.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6343 (e3420b1) into develop (97eb6a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6343   +/-   ##
========================================
  Coverage    79.75%   79.76%           
========================================
  Files          321      321           
  Lines        37329    37329           
  Branches      6756     6756           
========================================
+ Hits         29773    29775    +2     
+ Misses        7289     7286    -3     
- Partials       267      268    +1     
Components Coverage Δ
cvat-ui 77.11% <ø> (+0.01%) ⬆️
cvat-server 82.15% <100.00%> (-0.01%) ⬇️

@zhiltsov-max zhiltsov-max merged commit 1a2365c into develop Jun 20, 2023
@zhiltsov-max zhiltsov-max deleted the zm/fix-task-schema branch June 20, 2023 20:03
@azhavoro azhavoro mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants