Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missed auto_add argument #6364

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Added missed auto_add argument #6364

merged 6 commits into from
Jun 26, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 23, 2023

Motivation and context

Resolved #4394

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from mdacoca as a code owner June 23, 2023 06:20
@bsekachev bsekachev removed the request for review from mdacoca June 23, 2023 06:21
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #6364 (565870f) into develop (ea6c68f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6364      +/-   ##
===========================================
- Coverage    81.17%   81.16%   -0.02%     
===========================================
  Files          322      322              
  Lines        37782    37782              
  Branches      6821     6821              
===========================================
- Hits         30670    30666       -4     
- Misses        6803     6806       +3     
- Partials       309      310       +1     
Components Coverage Δ
cvat-ui 76.69% <ø> (-0.02%) ⬇️
cvat-server 85.16% <100.00%> (-0.02%) ⬇️

@bsekachev bsekachev requested a review from azhavoro as a code owner June 24, 2023 05:49
@bsekachev bsekachev merged commit bedbd82 into develop Jun 26, 2023
33 of 34 checks passed
@bsekachev bsekachev deleted the bs/fixed_issue_4394 branch June 28, 2023 08:31
azhavoro pushed a commit that referenced this pull request Jun 29, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

Resolved #4394

<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@azhavoro azhavoro mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not update the 'updated_date' value of an issue
3 participants