Fix overly broad exception conversion in LambdaFunction.invoke
#6394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of the `try`/`except` statement is to catch accesses to missing members of the `data` dictionary, but due to the large amount of code in the `try` block, it may end up catching entirely unrelated `KeyError`s. Those unrelated `KeyError`s should not be converted to `ValidationError`s, since they might not have anything to do with input validation, and the conversion will make it harder to debug these exceptions. An example of these misapplied conversions is a recent bug where a `KeyError` was coming from inside `_get_image` (fixed by f6420eb). To fix this, make sure to only catch `KeyError`s emitted by accesses to `data`.
|
Please check if this needs a new test in this application tests. |
Codecov Report
@@ Coverage Diff @@
## develop #6394 +/- ##
===========================================
- Coverage 80.04% 73.30% -6.74%
===========================================
Files 332 316 -16
Lines 38438 37538 -900
Branches 6923 6726 -197
===========================================
- Hits 30767 27519 -3248
- Misses 7355 9191 +1836
- Partials 316 828 +512
|
I don't think this change is testable, because it only makes a difference when there's an internal error in CVAT - which isn't supposed to happen. |
nmanovic
approved these changes
Jun 28, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
…t-ai#6394) The intent of the `try`/`except` statement is to catch accesses to missing members of the `data` dictionary, but due to the large amount of code in the `try` block, it may end up catching entirely unrelated `KeyError`s. Those unrelated `KeyError`s should not be converted to `ValidationError`s, since they might not have anything to do with input validation, and the conversion will make it harder to debug these exceptions. An example of these misapplied conversions is a recent bug where a `KeyError` was coming from inside `_get_image` (fixed by f6420eb). To fix this, make sure to only catch `KeyError`s emitted by accesses to `data`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The intent of the
try/exceptstatement is to catch accesses to missing members of thedatadictionary, but due to the large amount of code in thetryblock, it may end up catching entirely unrelatedKeyErrors. Those unrelatedKeyErrors should not be converted toValidationErrors, since they might not have anything to do with input validation, and the conversion will make it harder to debug these exceptions.An example of these misapplied conversions is a recent bug where a
KeyErrorwas coming from inside_get_image(fixed by f6420eb).To fix this, make sure to only catch
KeyErrors emitted by accesses todata.How has this been tested?
I manually checked that a) invoking functions still works, and b) omitting required parameters still results in a 400 error.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.