Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage fixes #6420

Merged
merged 13 commits into from
Jul 10, 2023
Merged

Code coverage fixes #6420

merged 13 commits into from
Jul 10, 2023

Conversation

yasakova-anastasia
Copy link
Contributor

@yasakova-anastasia yasakova-anastasia commented Jul 4, 2023

Motivation and context

  • Removed code coverage from full and schedule workflows
  • Updated codecov.yml
  • Fixed coverage saving in rqworker.py
  • Now one code coverage report is sent to codecov after passing all tests

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #6420 (19cebc6) into develop (4b179be) will increase coverage by 1.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6420      +/-   ##
===========================================
+ Coverage    80.41%   81.67%   +1.25%     
===========================================
  Files          332      334       +2     
  Lines        38426    38428       +2     
  Branches      6924     3536    -3388     
===========================================
+ Hits         30901    31385     +484     
+ Misses        7215     7043     -172     
+ Partials       310        0     -310     
Components Coverage Δ
cvat-ui 75.07% <ø> (-0.12%) ⬇️
cvat-server 87.78% <ø> (+2.52%) ⬆️

@yasakova-anastasia yasakova-anastasia changed the title Remove code coverage from full and schedule workflows Code coverage fixes Jul 6, 2023
@yasakova-anastasia
Copy link
Contributor Author

@kirill-sizov, could you please review this PR?

tests/python/rest_api/test_tasks.py Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
tests/python/requirements.txt Show resolved Hide resolved
@bsekachev bsekachev merged commit c31fbeb into develop Jul 10, 2023
@bsekachev bsekachev deleted the ay/code-coverage branch July 20, 2023 10:08
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
- Removed code coverage from full and schedule workflows
- Updated codecov.yml
- Fixed coverage saving in rqworker.py
- Now one code coverage report is sent to codecov after passing all
tests

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.

---------

Co-authored-by: yasakova-anastasia <anastasia@cvat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants