Ignore tasks without data during project export #6658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizov-kirill
requested review from
azhavoro,
zhiltsov-max and
Marishka17
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6658 +/- ##
===========================================
+ Coverage 82.25% 82.47% +0.21%
===========================================
Files 366 366
Lines 39767 39813 +46
Branches 3531 3538 +7
===========================================
+ Hits 32712 32835 +123
+ Misses 7055 6978 -77
|
zhiltsov-max
approved these changes
Aug 18, 2023
nmanovic
reviewed
Aug 23, 2023
| ((db_task.id, db_task) for db_task in self._db_project.tasks.order_by("subset","id").all()) | ||
| ( | ||
| (db_task.id, db_task) | ||
| for db_task in self._db_project.tasks.order_by("subset","id").all() |
There was a problem hiding this comment.
@kirill-sizov , why not .exclude(data=None) as in other places?
Merged
jonybekov
pushed a commit
to tezzro/cvat
that referenced
this pull request
Sep 6, 2023
### Motivation and context - Allow backup and export annotations for a project even if it has tasks without data - Add an error message on attempting to create backup of a task that has no data
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
### Motivation and context - Allow backup and export annotations for a project even if it has tasks without data - Add an error message on attempting to create backup of a task that has no data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.