-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cloudflare R2 Buckets #6701
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6701 +/- ##
===========================================
- Coverage 82.59% 82.55% -0.04%
===========================================
Files 360 360
Lines 38926 38977 +51
Branches 3570 3577 +7
===========================================
+ Hits 32150 32179 +29
- Misses 6776 6798 +22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's OK for now, but we probably need to remove the restriction for a secret key at all, because if I understand correctly AWS has no restriction for a Secret Access Key
(only for access key id). And we support other providers (like Oracle OCI and Cloudflare R2) only because they have compatible API with AWS S3, so we have to rely on the AWS S3 limitations.
Co-authored-by: Maria Khrustaleva <maria@cvat.ai>
Co-authored-by: Maria Khrustaleva <maria@cvat.ai>
@JonasHiltl , thank you for the great contribution. I'm ready to merge the PR. We have slightly changed how we are updating CHANGELOG. Could you please remove the line from CHANGELOG and use |
@nmanovic Thanks for coming back to me, I updated the Changelog entry and I'm looking forward to seeing this get merged. |
changelog.d/20231013_104143_jonashiltl2003_secret_key_length.md
Outdated
Show resolved
Hide resolved
It is currently not possible to add a Cloudflare R2 Bucket as a Cloud Storage source, since the Secret access key of R2 has a length of 64 but the ui/serializer restricts the length to 44. [This issue](cvat-ai#5512) addresses the same problem when using STORJ but with a max length of `128`. For me it would make the most sense to completely remove the max length, but this PR currently only fixes the R2 compatibility by increasing the max length to `64`.
Motivation and context
It is currently not possible to add a Cloudflare R2 Bucket as a Cloud Storage source, since the Secret access key of R2 has a length of 64 but the ui/serializer restricts the length to 44.
This issue addresses the same problem when using STORJ but with a max length of
128
.For me it would make the most sense to completely remove the max length, but this PR currently only fixes the R2 compatibility by increasing the max length to
64
.Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.