tests: don't run commands in the server container as root #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered an issue where the server process fails at startup due to being unable to create `/home/django/cache/events`, due to `/home/django/cache` being owned by `root`. I'm not sure how exactly that happened, but there are several commands involving Django or CVAT data that the test suite runs as root, and it had to be one of them that caused it. I don't think there's any reason to run these commands as root, so use `docker_exec_cvat` for them instead of `docker_exec`. This way, they will run as the Django user instead.
2 tasks
Codecov Report
@@ Coverage Diff @@
## develop #6717 +/- ##
===========================================
- Coverage 82.26% 82.26% -0.01%
===========================================
Files 366 366
Lines 39771 39771
Branches 3531 3531
===========================================
- Hits 32718 32716 -2
- Misses 7053 7055 +2
|
sizov-kirill
approved these changes
Aug 22, 2023
jonybekov
pushed a commit
to tezzro/cvat
that referenced
this pull request
Sep 6, 2023
I encountered an issue where the server process fails at startup due to being unable to create `/home/django/cache/events`, due to `/home/django/cache` being owned by `root`. I'm not sure how exactly that happened, but there are several commands involving Django or CVAT data that the test suite runs as root, and it had to be one of them that caused it. I don't think there's any reason to run these commands as root, so use `docker_exec_cvat` for them instead of `docker_exec`. This way, they will run as the Django user instead.
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
I encountered an issue where the server process fails at startup due to being unable to create `/home/django/cache/events`, due to `/home/django/cache` being owned by `root`. I'm not sure how exactly that happened, but there are several commands involving Django or CVAT data that the test suite runs as root, and it had to be one of them that caused it. I don't think there's any reason to run these commands as root, so use `docker_exec_cvat` for them instead of `docker_exec`. This way, they will run as the Django user instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
I encountered an issue where the server process fails at startup due to being unable to create
/home/django/cache/events, due to/home/django/cachebeing owned byroot.I'm not sure how exactly that happened, but there are several commands involving Django or CVAT data that the test suite runs as root, and it had to be one of them that caused it.
I don't think there's any reason to run these commands as root, so use
docker_exec_cvatfor them instead ofdocker_exec. This way, they will run as the Django user instead.How has this been tested?
Unit tests.
Checklist
developbranch[ ] I have added a description of my changes into the CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.