Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the backend entrypoint #6750

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Aug 24, 2023

Motivation and context

  • Make it possible to run migrations without starting the server, and vice versa. This is not yet used, but it will be needed later to enable database initialization/upgrade in a configuration with multiple server containers.

  • Wait for migrations to complete in worker containers, to be safe. Workers also use the database.

  • Add a help message and a way to run the shell (useful for development).

  • Add support for initialization scripts, which helps simplify the smokescreen hack needed for the webhook tests.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

* Make it possible to run migrations without starting the server, and vice versa.
  This is not yet used, but it will be needed later to enable database
  initialization/upgrade in a configuration with multiple server containers.

* Wait for migrations to complete in worker containers, to be safe. Workers also
  use the database.

* Add a help message and a way to run the shell (useful for development).

* Add support for initialization scripts, which helps simplify the smokescreen hack
  needed for the webhook tests.
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #6750 (5fd2e02) into develop (2ce6a3c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6750   +/-   ##
========================================
  Coverage    82.42%   82.43%           
========================================
  Files          366      366           
  Lines        39832    39832           
  Branches      3545     3545           
========================================
+ Hits         32833    32834    +1     
+ Misses        6999     6998    -1     
Components Coverage Δ
cvat-ui 77.40% <ø> (ø)
cvat-server 86.82% <ø> (+<0.01%) ⬆️

@SpecLad SpecLad merged commit f9608e8 into cvat-ai:develop Aug 29, 2023
32 checks passed
@SpecLad SpecLad deleted the rework-entrypoint branch August 29, 2023 08:20
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
* Make it possible to run migrations without starting the server, and
vice versa. This is not yet used, but it will be needed later to enable
database initialization/upgrade in a configuration with multiple server
containers.

* Wait for migrations to complete in worker containers, to be safe.
Workers also use the database.

* Add a help message and a way to run the shell (useful for
development).

* Add support for initialization scripts, which helps simplify the
smokescreen hack needed for the webhook tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants