-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues 6836 6837 #6850
Fix issues 6836 6837 #6850
Conversation
@@ -171,6 +171,18 @@ function RemoteBrowser(props: Props): JSX.Element { | |||
} | |||
}; | |||
collectNodes(content); | |||
|
|||
if (manifestPath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this manifest file labeled in screenshot going to be added to the files being uploaded and is it going to affect to predefined sorting method #6836? @Marishka17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bedilbek, Yes, such manifest will be added to the list of files and the sequence of frames will be determined based on manifest content (in case of using predefined
sorting).
Codecov Report
@@ Coverage Diff @@
## develop #6850 +/- ##
===========================================
+ Coverage 82.49% 82.51% +0.01%
===========================================
Files 370 370
Lines 39831 39836 +5
Branches 3549 3549
===========================================
+ Hits 32860 32871 +11
+ Misses 6971 6965 -6
|
key: manifestPath, | ||
children: [], | ||
type: 'REG', | ||
mimeType: 'unknown', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why mimeType is unknown? application/jsonl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was sure that mimeType
in such a structure generally is defined from the server content and it can be only image
/video
/archive
/pdf
/DIR
/unknown
.
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
Resolve cvat-ai#6837 Resolve cvat-ai#6836
Motivation and context
Resolve #6837
Resolve #6836
How has this been tested?
Checklist
develop
branch- [ ] I have updated the documentation accordingly(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.