Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reload the page when changing job state #6851

Merged
merged 7 commits into from
Sep 15, 2023

Conversation

bsekachev
Copy link
Member

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] Do not reload the page when changing job state Do not reload the page when changing job state Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #6851 (77a6940) into develop (8962c12) will increase coverage by 0.01%.
Report is 14 commits behind head on develop.
The diff coverage is 65.85%.

@@             Coverage Diff             @@
##           develop    #6851      +/-   ##
===========================================
+ Coverage    82.49%   82.51%   +0.01%     
===========================================
  Files          370      370              
  Lines        39831    39850      +19     
  Branches      3549     3556       +7     
===========================================
+ Hits         32860    32883      +23     
+ Misses        6971     6967       -4     
Components Coverage Δ
cvat-ui 77.57% <65.85%> (+0.04%) ⬆️
cvat-server 86.86% <ø> (ø)

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a line to CHANGELOG and update cvat-ui package version

Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive we can merge it

@bsekachev
Copy link
Member Author

@klakhov

I am planning to do that after release.

@bsekachev bsekachev merged commit b2957ab into develop Sep 15, 2023
13 checks passed
@bsekachev bsekachev deleted the bs/avoid_reloading_job branch September 16, 2023 11:45
@azhavoro azhavoro mentioned this pull request Sep 25, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants