Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy extra files if both server_files and job_file_mapping are… #6879

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

azhavoro
Copy link
Contributor

… specified

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #6879 (bf6fe49) into develop (657e361) will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##           develop    #6879      +/-   ##
===========================================
- Coverage    82.51%   82.50%   -0.02%     
===========================================
  Files          370      370              
  Lines        39854    39861       +7     
  Branches      3559     3559              
===========================================
  Hits         32887    32887              
- Misses        6967     6974       +7     
Components Coverage Δ
cvat-ui 77.55% <ø> (-0.02%) ⬇️
cvat-server 86.85% <14.28%> (-0.02%) ⬇️

@nmanovic
Copy link
Contributor

@azhavoro , could you please add a line into CHANGELOG.md?

Also need to add some notes into swagger documentation about these parameters. Thus, it will be easy to recall the behavious.

@azhavoro azhavoro force-pushed the az/fix_cloud_storage branch from cbda68f to 1b0aa32 Compare September 20, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants