Remove unnecessary COUNT for labels #6918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
SpecLad
reviewed
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## develop #6918 +/- ##
========================================
Coverage 82.31% 82.32%
========================================
Files 361 361
Lines 39168 39167 -1
Branches 3586 3586
========================================
Hits 32243 32243
+ Misses 6925 6924 -1
|
SpecLad
requested changes
Oct 13, 2023
SpecLad
reviewed
Oct 13, 2023
SpecLad
approved these changes
Oct 18, 2023
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
Optimized /api/projects, /api/tasks, and /api/jobs requests. Previously for unification, we decided to add a count of labels into every response for each project, task, and job. It leads to performance issues. UI and probably other clients don't use the information because it is useless. Removing it, helps to optimize the SQL request several times. --------- Co-authored-by: Boris Sekachev <boris@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized /api/projects, /api/tasks, and /api/jobs requests. Previously for unification, we decided to add a count of labels into every response for each project, task, and job. It leads to performance issues. UI and probably other clients don't use the information because it is useless. Removing it, helps to optimize the SQL request several times.