Sort frames during project dumping #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6927 +/- ##
===========================================
- Coverage 82.61% 82.59% -0.02%
===========================================
Files 360 360
Lines 38868 38868
Branches 3544 3544
===========================================
- Hits 32110 32104 -6
- Misses 6758 6764 +6
|
|
Hi, do you know if we can add a test reproducing the problem? From what I see, the problem is related to how the frame data is returned from DB, and it can be unreliable. |
This problem is hard to reproduce due to the reason that you mentioned, so I don't know how it can be tested. |
zhiltsov-max
approved these changes
Oct 4, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
When we export a task or project in CVAT format [our code uses](https://github.com/opencv/cvat/blob/d497bb6a90dd3c9625c3c8e8f73278019e21983d/cvat/apps/dataset_manager/formats/cvat.py#L717) the `group_by_frame` function. For tasks and for projects behaviour of this function is different since for tasks [we perform sorting frames](https://github.com/opencv/cvat/blob/d497bb6a90dd3c9625c3c8e8f73278019e21983d/cvat/apps/dataset_manager/bindings.py#L420-L421) but for projects [we don't](https://github.com/opencv/cvat/blob/d497bb6a90dd3c9625c3c8e8f73278019e21983d/cvat/apps/dataset_manager/bindings.py#L1152-L1154). As a result, we can have a situation when our annotation file for the project will have a list of images in unsorted form. So this PR adds sorting frames during project export as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
When we export a task or project in CVAT format our code uses the
group_by_framefunction. For tasks and for projects behaviour of this function is different since for tasks we perform sorting frames but for projects we don't. As a result, we can have a situation when our annotation file for the project will have a list of images in unsorted form. So this PR adds sorting frames during project export as well.How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.