Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added temporary workaround to fix corrupted zip file #6965

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Added temporary workaround to fix corrupted zip file #6965

merged 2 commits into from
Oct 9, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 9, 2023 •
edited
Loading

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

klakhov
klakhov reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code perspective fix looks ok.

@azhavoro Could you check if this really works on your reproducing scenario?

@azhavoro
Copy link
Contributor

azhavoro commented Oct 9, 2023

@klakhov It works as expected

@bsekachev bsekachev merged commit e699848 into develop Oct 9, 2023
31 of 32 checks passed
@azhavoro azhavoro mentioned this pull request Oct 9, 2023
Merged
This was referenced Oct 10, 2023
Closed
Merged
@bsekachev bsekachev deleted the bs/corrupted_zip_workaround branch October 12, 2023 05:57
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
@bsekachev @mikhail-treskin
Added temporary workaround to fix corrupted zip file (cvat-ai#6965)
4d602a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsekachev @azhavoro @klakhov